add sentry to grid deployer #1269
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rawdaGastan
requested review from
mariobassem,
ashraffouda,
Omarabdul3ziz,
AbdelrahmanElawady,
xmonader,
sameh-farouk and
Eslam-Nawara
as code owners
rawdaGastan
force-pushed
the
development_sentry
branch
from
c124d3e to
ae48e92
Compare
rawdaGastan
force-pushed
the
development_sentry
branch
from
ae48e92 to
33a2f17
Compare
|
|
||
| return gridSentry{ | ||
| sentryInfo: &sentryInfo{twinID: twinID}, | ||
| }, sentry.Init(sentry.ClientOptions{ |
There was a problem hiding this comment.
I suggest you initialize sentry in a separate step so it's clear what you're doing
There was a problem hiding this comment.
Didn't get what you mean?
grid-client/deployer/sentry.go
Outdated
Comment on lines
9
to
15
| type gridSentry struct { | ||
| *sentryInfo | ||
| } | ||
|
|
||
| type sentryInfo struct { | ||
| twinID uint32 | ||
| } |
There was a problem hiding this comment.
is there a reason for creating two structs here?
There was a problem hiding this comment.
for clearance but I can merge them
| }, sentry.Init(sentry.ClientOptions{ | ||
| Dsn: SentryDSN[network], | ||
| Environment: network, | ||
| Debug: true, |
There was a problem hiding this comment.
can you use the debug flag passed on creating the plugin
There was a problem hiding this comment.
It is different here as we will check the issues info and we need to have all debug info so the user shouldn't decide it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues